Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instrument additional data points #7543

Merged
merged 7 commits into from
Jan 31, 2025
Merged

Instrument additional data points #7543

merged 7 commits into from
Jan 31, 2025

Conversation

konstantin-msft
Copy link
Collaborator

  • Instrument RT expiration time when running into interaction_required errors.
  • Instrument system.asyncPopups config param.
  • Instrument usage of loginHint, domainHint and SID.

@github-actions github-actions bot added msal-browser Related to msal-browser package msal-common Related to msal-common package documentation Related to documentation. labels Jan 30, 2025
@konstantin-msft
- Instrument RT expiration time when running into interaction_require…
ca2c948 
…d errors.

- Instrument `system.asyncPopups` config param.
- Instrument usage of loginHint, domainHint and SID.
@konstantin-msft
Change files
a0faf68
@konstantin-msft
- Update API docs.
da6dfe8
@konstantin-msft konstantin-msft force-pushed the instrument_additional_attributes branch from 05f5ebd to da6dfe8 Compare January 30, 2025 20:41
@konstantin-msft
- Instrument prompt.
8f5ebce 
- Instrument sid and loginHint/domainHint wrt to origin.
@konstantin-msft konstantin-msft merged commit fb0dc47 into dev Jan 31, 2025
8 checks passed
@konstantin-msft konstantin-msft deleted the instrument_additional_attributes branch January 31, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterzenz peterzenz peterzenz approved these changes

@sameerag sameerag sameerag approved these changes

@hectormmg hectormmg Awaiting requested review from hectormmg hectormmg is a code owner

@jo-arroyo jo-arroyo Awaiting requested review from jo-arroyo jo-arroyo is a code owner

@Robbie-Microsoft Robbie-Microsoft Awaiting requested review from Robbie-Microsoft Robbie-Microsoft is a code owner

@lalimasharda lalimasharda Awaiting requested review from lalimasharda lalimasharda is a code owner

@shylasummers shylasummers Awaiting requested review from shylasummers shylasummers is a code owner

@tnorling tnorling Awaiting requested review from tnorling tnorling is a code owner

Assignees
No one assigned
Labels
documentation Related to documentation. msal-browser Related to msal-browser package msal-common Related to msal-common package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@konstantin-msft @tnorling @sameerag @peterzenz